Skip to content

HomeKit motion sensor review feedback#20568

Merged
cgarwood merged 1 commit intohome-assistant:devfrom
Jc2k:homekit_review_1
Jan 29, 2019
Merged

HomeKit motion sensor review feedback#20568
cgarwood merged 1 commit intohome-assistant:devfrom
Jc2k:homekit_review_1

Conversation

@Jc2k
Copy link
Copy Markdown
Member

@Jc2k Jc2k commented Jan 29, 2019

Description:

@MartinHjelmare left some review on one of my PR's but it had already been merged. This PR actions that feedback.

Related issue (if applicable): #20555

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jan 29, 2019
@Jc2k Jc2k changed the title Review feedback HomeKit motion sensor review feedback Jan 29, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@cgarwood cgarwood merged commit e0e5b86 into home-assistant:dev Jan 29, 2019
@ghost ghost removed the in progress label Jan 29, 2019
@balloob balloob mentioned this pull request Feb 6, 2019
@Jc2k Jc2k deleted the homekit_review_1 branch March 1, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants